Skip to content

🐛 revert to previous long_running_tasks interface #7903

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

🐛 revert to previous long_running_tasks interface #7903

wants to merge 5 commits into from

Conversation

@GitHK
Copy link
Contributor

@GitHK GitHK commented Jun 16, 2025 •
edited
Loading

What do these changes do?

The interface of long_running_tasks got accidentally changed by altering a test, causing director-v2 to no longer tread errors as it should.

Also task removal was also accidentally changed and not sopped during reviews, this was also reverted, to avoid code raising unexpected errors.

Related issue/s

How to test

Dev-ops

@codecov
Copy link

codecov bot commented Jun 16, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 90.24390% with 4 lines in your changes missing coverage. Please review.

Project coverage is 87.84%. Comparing base (975e587) to head (b0d7c19).
Report is 13 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7903      +/-   ##
==========================================
- Coverage   87.94%   87.84%   -0.10%     
==========================================
  Files        1845     1428     -417     
  Lines       71141    59344   -11797     
  Branches     1220      623     -597     
==========================================
- Hits        62562    52131   -10431     
+ Misses       8227     7004    -1223     
+ Partials      352      209     -143
Flag Coverage Δ
integrationtests 64.22% <ø> (-0.01%) ⬇️
unittests 86.05% <90.24%> (-0.49%) ⬇️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library ∅ <ø> (∅)
pkg_dask_task_models_library ∅ <ø> (∅)
pkg_models_library ∅ <ø> (∅)
pkg_notifications_library ∅ <ø> (∅)
pkg_postgres_database ∅ <ø> (∅)
pkg_service_integration ∅ <ø> (∅)
pkg_service_library 72.68% <90.24%> (+0.08%) ⬆️
pkg_settings_library ∅ <ø> (∅)
pkg_simcore_sdk 85.10% <ø> (ø)
agent 96.29% <ø> (ø)
api_server 91.85% <ø> (ø)
autoscaling 96.03% <ø> (ø)
catalog 92.29% <ø> (ø)
clusters_keeper 99.13% <ø> (ø)
dask_sidecar 91.79% <ø> (ø)
datcore_adapter 97.94% <ø> (ø)
director 76.73% <ø> (-0.10%) ⬇️
director_v2 91.12% <ø> (+0.02%) ⬆️
dynamic_scheduler 96.69% <ø> (ø)
dynamic_sidecar 90.06% <ø> (-0.04%) ⬇️
efs_guardian 89.65% <ø> (ø)
invitations 93.00% <ø> (ø)
payments 92.57% <ø> (ø)
resource_usage_tracker 88.98% <ø> (ø)
storage 87.60% <ø> (+0.14%) ⬆️
webclient ∅ <ø> (∅)
webserver 87.47% <ø> (-0.01%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 975e587...b0d7c19. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 16, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@GitHK GitHK changed the title 🐛 revert accidentally removed code 🐛 revert to previous long_running_tasks interface Jun 16, 2025
@GitHK GitHK marked this pull request as ready for review June 16, 2025 13:43
@GitHK GitHK requested a review from pcrespov as a code owner June 16, 2025 13:43
@GitHK GitHK self-assigned this Jun 16, 2025
@GitHK GitHK added this to the Engage milestone Jun 16, 2025
@GitHK GitHK added the 🤖-automerge marks PR as ready to be merged for Mergify label Jun 16, 2025
@GitHK
Copy link
Contributor Author

GitHK commented Jun 16, 2025 •
edited by pcrespov
Loading

@Mergifyio queue

@mergify
Copy link
Contributor

mergify bot commented Jun 16, 2025

merge

❌ Sorry but I didn't understand the command. Please consult the commands documentation 📚.

@mergify
Copy link
Contributor

mergify bot commented Jun 17, 2025 •
edited
Loading

queue

🟠 Waiting for conditions to match

  • -closed [📌 queue requirement]
  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • label=🤖-automerge
      • any of: [🛡 GitHub branch protection]
        • check-neutral = system-tests
        • check-skipped = system-tests
        • check-success = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-neutral = unit-tests
        • check-skipped = unit-tests
        • check-success = unit-tests
      • #approved-reviews-by >= 2 [🛡 GitHub branch protection]
      • #approved-reviews-by>=2
      • #changes-requested-reviews-by = 0 [🛡 GitHub branch protection]
      • #changes-requested-reviews-by=0
      • #review-threads-unresolved = 0 [🛡 GitHub branch protection]
      • #review-threads-unresolved=0
      • -conflict
      • -draft
      • base=master
      • branch-protection-review-decision = APPROVED [🛡 GitHub branch protection]
      • label!=🤖-do-not-merge
      • any of: [🛡 GitHub branch protection]
        • check-skipped = deploy to dockerhub
        • check-neutral = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-success = check OAS' are up to date
        • check-neutral = check OAS' are up to date
        • check-skipped = check OAS' are up to date
      • any of: [🛡 GitHub branch protection]
        • check-success = integration-tests
        • check-neutral = integration-tests
        • check-skipped = integration-tests
      • any of: [🛡 GitHub branch protection]
        • check-success = build-test-images (frontend) / build-test-images
        • check-neutral = build-test-images (frontend) / build-test-images
        • check-skipped = build-test-images (frontend) / build-test-images
  • -conflict [📌 queue requirement]
  • -draft [📌 queue requirement]
  • any of: [📌 queue -> configuration change requirements]
    • -mergify-configuration-changed
    • check-success = Configuration changed

@GitHK GitHK removed 🤖-automerge marks PR as ready to be merged for Mergify labels Jun 17, 2025
@GitHK GitHK mentioned this pull request Jun 17, 2025
Merged
@mergify mergify bot closed this in #7914 Jun 18, 2025
@GitHK GitHK deleted the pr-osparc-fix-long-running-tasks-error-handling branch June 18, 2025 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@pcrespov pcrespov pcrespov approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@bisgaard-itis bisgaard-itis Awaiting requested review from bisgaard-itis

Assignees

@GitHK GitHK

Labels

None yet

Projects

None yet

Milestone

Engage

Development

Successfully merging this pull request may close these issues.

FastAPI long_running_tasks client interface broken

5 participants

@GitHK @giancarloromeo @pcrespov @sanderegg @matusdrobuliak66